Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFF seqid may violate gff3 spec #18

Closed
zdk123 opened this issue Oct 20, 2022 · 4 comments
Closed

GFF seqid may violate gff3 spec #18

zdk123 opened this issue Oct 20, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@zdk123
Copy link

zdk123 commented Oct 20, 2022

Thanks for this tool! One comment and a request:

It looks like the GFF output format here is slightly different than prodigal, and (maybe) the gff3 specs. This is preventing us using pyrodigal as a drop-in replacement.

Prodigal uses the input contig name for the seqid, while pyrodigal uses prefix/gene_{i} , which seems to violate this spec:

Column 1: "seqid"
The ID of the landmark used to establish the coordinate system for the current feature...

The landmark for the gene coordinates obviously cannot be the gene id itself.

What would be great is if instead the prefix could modify the ID component of the _gene_data which would add an enhancement over the gff output provided by prodigal without violating the spec.

@althonos althonos added the bug Something isn't working label Oct 21, 2022
@althonos
Copy link
Owner

Oh yes, this is a mistake on my end, sorry 🤐 I'll update this part for v1.2.

@althonos
Copy link
Owner

I'm pushing a pre-release that you can test on your side (v2.0.0-rc.1). This will need a bump in major version since I ended up changing the signature of all write methods. I'll try to fix #19 before releasing the actual v2.

@zdk123
Copy link
Author

zdk123 commented Oct 22, 2022

Wow that was fast, thank you I'll test this out soon!

@althonos
Copy link
Owner

althonos commented Nov 1, 2022

Marking this as fixed since v2.0.0 will now use the sequence identifier in the first column and create a gene identifier for the ID attribute.

@althonos althonos closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants