Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gene size parameters to CLI #32

Merged
merged 2 commits into from Feb 17, 2023
Merged

add gene size parameters to CLI #32

merged 2 commits into from Feb 17, 2023

Conversation

cjprybol
Copy link
Contributor

#31

Didn't run any tests but I think this is the right place to make the edits

Copy link
Owner

@althonos althonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you just change the flags to be in kebab-case (--min-edge-gene instead of --min_edge_gene)?

@cjprybol
Copy link
Contributor Author

Do you have any preferences for short-hand CLI flags? These are not in the prodigal CLI so there's no existing reference to work off of, but I also struggled to think of any obvious one-letter choices and skipped them so far.

-o, -m and -g are already taken, but something like -l for min_gene ( L ength), -e for min e dge gene, and/or -p for overla p could work?

I almost always default to long-form myself for clarity so I'm indifferent - happy to go with whatever you prefer!

I also think we're good with the arg parsing and referencing. I initially switched to use the var(args)['argument-name-here'] format but looks like it will auto-replace dashes with underscores so I left the argument passing as is

@althonos
Copy link
Owner

I also think we're good with the arg parsing and referencing. I initially switched to use the var(args)['argument-name-here'] format but looks like it will auto-replace dashes with underscores so I left the argument passing as is

Yes exactly, that's why I asked about the kebab case, since argparse already handles the conversion!

Do you have any preferences for short-hand CLI flags? These are not in the prodigal CLI so there's no existing reference to work off of, but I also struggled to think of any obvious one-letter choices and skipped them so far.

I'm fine not having a shortcut, since these are not standard Prodigal arguments, it makes sense to write them out in long-form!

@althonos althonos merged commit f50531e into althonos:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants