Handle unencoded Location headers #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: #4 In production, we've seen a few shorteners return unencoded URIs in their Location headers (contrary to the RFC 7231 specification). We could use URI.escape and URI.unescape to deal with these but they have been deprecated. Instead, bring in the Addressable gem as a dependency to handle normalisation. This means that Embiggen now returns Addressable::URIs rather than Ruby standard library URIs which is a breaking API change if you rely on URI-specific features (e.g. port which is much stricter with Addressable).
|
Going to re-open this against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: #4
In production, we've seen a few shorteners return unencoded URIs in their Location headers (contrary to the RFC 7231 specification). We could use
URI.escapeandURI.unescapeto deal with these but they have been deprecated. Instead, bring in the Addressable gem as a dependency to handle normalisation.This means that Embiggen now returns
Addressable::URIsrather than Ruby standard libraryURIs which is a breaking API change if you rely onURI-specific features (e.g.portwhich is much stricter with Addressable).