refactoring GetIsCollidedWith #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durswd
reviewed
Jan 28, 2021
| @@ -40,6 +40,19 @@ void Collider::SetTransform(const Matrix44F& transform) { | |||
| rotation_ = r; | |||
| } | |||
|
|
|||
| bool Collider::GetIsCollidedWith(std::shared_ptr<Collider> collider) { return GetIsCollidedWith_(collider); } | |||
| bool Collider::GetIsCollidedWith(std::shared_ptr<Collider> collider) { | |||
| float radius_; | ||
|
|
||
| bool GetIsCollidedWith_(std::shared_ptr<Collider> shape) override; | ||
| protected: | ||
| std::pair<b2Shape*, int32_t> GetB2Shapes() override { return {&shape_, 1}; } |
There was a problem hiding this comment.
綺麗やるなら内部的にShapeCollectionクラス等を用意してそれを返すようにしたほうがいい気がする
There was a problem hiding this comment.
ポインタに関してはunique_ptrでもつとかしか手段思いつかないですね...
There was a problem hiding this comment.
ただの値の場合とstd::vectorの場合を同一視している荒技なので、どうしたものか。
There was a problem hiding this comment.
ShapeCollectionというのは、このタプル相当のフィールドを持ったclassという感じの……？
wistnki
reviewed
Jan 29, 2021
| float radius_; | ||
|
|
||
| bool GetIsCollidedWith_(std::shared_ptr<Collider> shape) override; | ||
| protected: | ||
| std::pair<b2Shape*, int32_t> GetB2Shapes() override { return {&shape_, 1}; } |
wraikny
force-pushed
the
refactoring-get-is-collided-with
branch
from
b98d6fb
to
9d32535
Compare
durswd
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes/変更内容
Collider周りのリファクタリングです。
全てのクラスの組み合わせについて
b2TestOverlapを呼び出す処理が書かれていて酷かったので、抽象化しました。ただし生ポインタを使ってしまっているので、もう少しうまい方法があれば教えてください。
Issue