Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitu doesn't build on Windows #39

Closed
barba3 opened this issue Mar 7, 2024 · 3 comments
Closed

gitu doesn't build on Windows #39

barba3 opened this issue Mar 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@barba3
Copy link

barba3 commented Mar 7, 2024

I tried installing gitu on Windows with cargo install --git https://github.com/altsem/gitu.git --locked, but it failed because the code uses signal_hook::iterator.

As per https://docs.rs/signal-hook/latest/signal_hook/iterator/index.html, signal_hook::iterator is not for Windows:

"Available non-Windows and crate feature iterator only."

@altsem
Copy link
Owner

altsem commented Mar 7, 2024

Ah, added this for dev, purposes. But I don't think it's needed. If you remove it, does everything work?

@altsem altsem added the bug Something isn't working label Mar 7, 2024
@altsem
Copy link
Owner

altsem commented Mar 8, 2024

@barba3 i made a new release where this should be fixed. If you can confirm it works, I'll close this! :)

@barba3
Copy link
Author

barba3 commented Mar 8, 2024

@altsem thank you for the quick fix!
I tried installing it on Windows with cargo install gitu --locked and it installed correctly. Then I ran gitu and it worked well.

@barba3 barba3 closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants