Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Transcript have segment number missing #31

Closed
ngoel17 opened this issue Oct 27, 2015 · 1 comment
Closed

Final Transcript have segment number missing #31

ngoel17 opened this issue Oct 27, 2015 · 1 comment

Comments

@ngoel17
Copy link

ngoel17 commented Oct 27, 2015

Since the creation of JSON for final was moved to the plugin, it is missing the segment number, while the partial transcripts contain the segment number. This is a little confusing, and probably the we would need to keep two separate counters so that both have segment numbers. Maybe move the partial creation also to the plugin.
alumae added a commit that referenced this issue Oct 27, 2015
@alumae
Add segment nr to final JSON, corrects #31
e08030d
@alumae
Copy link
Owner

alumae commented Oct 27, 2015

I fixed it by adding the segment nr to the final JSON inside the worker.

@alumae alumae closed this as completed Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alumae @ngoel17