New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup: property attributes and manual property synthesis #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXUP import operations
cc @MaddTheSane you've done a lot of cleanup work around property attributes - this integrates your latest changes, and I'd appreciate your eyes on this in case I've inadvertently regressed something. |
MaddTheSane
approved these changes
Apr 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This was referenced Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off https://github.com/alunbestor/Boxer/tree/64bit/master, which is a clone of MaddTheSane@234a6a7
This PR cleans up a swathe of classes to do the following:
@synthesize propertyName = _ivarName
) except for properties defined in protocols..m
and.mm
files.This PR also clarifies a bunch of redundant or inappropriate
@property
attributes, according to the following rules:assign
from non-object properties (this is inferred)nonatomic
to properties that are not expected to be thread-safe (almost all of them)atomic
to properties that actually are expected to be thread-safe (mostly around async operations and rendering)nullable
fromweak
properties (this is implied)copy
,weak
andstrong
from computedreadonly
properties (these attributes are only relevant for stored properties, not computed ones)delegate
-style properties asweak
, or in rare casesunsafe_unretained
(where code clearly relies on the property having a value)weak
IBOutlets asstrong
instead (this is now Apple's recommended practice)Some classes with complex sets of ivars (e.g.
BXSession
andBXEmulator
) have not yet been migrated, as they need additional work to expose necessary properties to subclasses/subcomponents. I have no doubt also missed a bunch of property attributes too.