-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the addition of Embedded Binaries #78
Comments
+1 |
For the time being, here's a workaround I implemented: |
@aabluedragon isn't your workaround for Embedded Framework and not Embedded binary? |
@jainpiyushb It is, however the Xcode section refers to it by the name "Embedded Binaries" (and The framework contains the binary itself) also note that the headers are removed upon build (as opposed to the binary). |
Hi @aabluedragon , Line 300 in 078625f
|
Debugged this. The embed option will only add the framework if the "Copy Files" phase (that has to be named "Embed Frameworks") exists. |
I believe this feature is already implemented. Here's some code that should work: let embed = true,
link = false,
frameworkPath = '/Users/me/Desktop/MyFramework.framework',
project; // the node-xcode pbxProject reference
let existsEmbedFrameworks = project.buildPhaseObject('PBXCopyFilesBuildPhase', 'Embed Frameworks');
if (!existsEmbedFrameworks && embed) {
console.log('"Embed Frameworks" Build Phase (Embedded Binaries) does not exist, creating it.');
project.addBuildPhase([], 'PBXCopyFilesBuildPhase', 'Embed Frameworks', null, 'frameworks');
}
let options = { customFramework: true, embed: embed, link: link, sign: true };
project.addFramework(frameworkPath, opt); |
I need to be able to programmatically add embedded binaries (Cordova & a 3rd party dynamic framework being used), but I cannot see how I am able to do this using this XCode node module.
Is there plans on having this supported sometime in the future? Is this already supported and I am missing something?
Thanks!
The text was updated successfully, but these errors were encountered: