Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies support #62

Closed
neslinesli93 opened this issue Mar 14, 2018 · 2 comments
Closed

Cookies support #62

neslinesli93 opened this issue Mar 14, 2018 · 2 comments
Labels
bug help wanted PR welcome

Comments

@neslinesli93
Copy link

I was having difficulties getting the cookies to be sent with my request, and I think I may have found the problem. This function here is missing cookies assignment, and therefore the resulting cookies array is always empty.

Am I missing something? Thanks for the library by the way - it's just awesome!
@lsaini
Copy link

lsaini commented Mar 16, 2018

I agree. Same case was with me as well and cookies were not set.

@kimmobrunfeldt
Copy link
Member

Seems like a bug yes. I've missed this part in the PR review. Bug fix PR welcome.

@esvitaly esvitaly mentioned this issue Sep 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neslinesli93 @kimmobrunfeldt @lsaini