Make RequestDetailTabRawPayload show actual raw data
#1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RequestDetailTabRawPayload` is currently rendering `FlightResponseChunkRaw`, which is in turn rendering `originalValue` from chunks. While this data does show some parts of the original response text, it has already gone through one level of parsing, so the row references at the beginning ot the lines are gone. By directly using event data made accessible via #1058, we can show the real original text instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RequestDetailTabRawPayloadis currently renderingFlightResponseChunkRaw, which is in turn renderingoriginalValuefrom chunks. While this data does show some parts of the original response text, it has already gone through one level of parsing, so the row references at the beginning ot the lines are gone.By directly using event data made accessible via #1058, we can show the real original text instead.
Before
After