Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add volume to historical_data's output if exists #22

Merged
merged 2 commits into from
Oct 8, 2022
Merged

✨ Add volume to historical_data's output if exists #22

merged 2 commits into from
Oct 8, 2022

Conversation

alvarobartt
Copy link
Owner

✨ Features

  • Add volume to historical_data's output if volume exists
  • Add missing assertion for volume column in historica_data's output

🔗 Linked Issue

#17

🧪 Tests

  • Did you implement unit tests if required?

If the above checkbox is checked, describe how you unit-tested it.

Add missing value (volume) in list with column names for assertion over historical_data's output to pass.

@alvarobartt alvarobartt added the enhancement New feature or request label Oct 8, 2022
@alvarobartt alvarobartt self-assigned this Oct 8, 2022
@alvarobartt alvarobartt linked an issue Oct 8, 2022 that may be closed by this pull request
volume data #17
Closed
@alvarobartt alvarobartt merged commit 2bf8e4c into main Oct 8, 2022
@alvarobartt alvarobartt deleted the add-volume branch October 8, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alvarobartt alvarobartt

Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volume data
1 participant
@alvarobartt