✨ Add info, investing_info, and solve timezone issue
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for timezone conversion on `historical_data`'s output depending on the asset e.g. U.S. 10 Y Bond Yield operating in timezone America/New_York
Since we can retrieve the proper asset's timezone from Investing.com, we're using `pytz` to convert the timestamps to their actual timezone
alvarobartt
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Features
/quotesand/symbolshttps://tvc4.investing.com endpoints underinfoandinvesting_info, respectively.pytzdependency to handle timezones, as it's more complete thandatetime.timezone🐛 Bug Fixes
historical_data's output dates, as withinvesting_infowe can retrieve the operating timezone of each asset and usepytzto properly convert the timestamps🔗 Linked Issue
#40
🧪 Tests
If the above checkbox is checked, describe how you unit-tested it.
investiny.infohas been unit tested with the different input types available, andinvestiny.investing_infohas not been tested yet, as it's just used internally and everything is already handled.