馃悰 Fix recurrent bug with non-matching dates #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some assets such as the bond yields have incorrect timestamps shifted by one day, and doesn't seem to be related with timezone issues, as previously thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 Bug Fixes
timedelta(days=1)todatetime.now()objects when interval is either daily, weekly, or monthly.馃敆 Linked Issue
#40
馃И Tests
If the above checkbox is checked, describe how you unit-tested it.
Current unit tests were not passing due to the timezone conversions, but after implementing the day-shift mechanism, those are working back again, since the timezones didn't have anything to do with the bug.