Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function: investpy.technical - add 1 minute interval #277

Closed
SladeSantos opened this issue Jan 27, 2021 · 7 comments
Closed

function: investpy.technical - add 1 minute interval #277

SladeSantos opened this issue Jan 27, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@SladeSantos
Copy link

Good Morning!
Friend, would you add the 1 minute interval in the function: investpy.technical.moving_averages (name = 'EUR / USD', country = None, product_type = 'currency_cross', interval = '5mins')?

@alvarobartt alvarobartt self-assigned this Jan 27, 2021
@alvarobartt alvarobartt added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 27, 2021
@alvarobartt alvarobartt added this to To do in investpy v1.1.0 via automation Jan 27, 2021
@alvarobartt
Copy link
Owner

Hi @SladeSantos! 🤗

I can add it if it's available at Investing.com, so could you share the URL where I can check that it's available? Once I check that, if Investing.com provides that information, including it in investpy is trivial, so just let me know and I'll include it if possible.

BTW give it a look at ta which is a project from @bukosabino, you may like it if you are interested on technical indicators and technical analysis. 👍🏻

@SladeSantos
Copy link
Author

SladeSantos commented Jan 27, 2021

Follow the link: https://www.investing.com/currencies/eur-nzd-technical

In any currency pair there is the option of technical analysis for the interval of 1min, 5min, 15min ...

In this case, in the API we only haven't the option of 1min.

@alvarobartt
Copy link
Owner

Ok thanks @SladeSantos I will include this tomorrow as well as the tests so that you can start using this from the source version. I will give you more details tomorrow regarding the installation from source, so that you can just follow those steps! 👍🏻

@SladeSantos
Copy link
Author

Right friend,
I'm waiting!

Thanks for listening!
Good Morning!

@SladeSantos
Copy link
Author

investpy -> utils -> constant.py

INTERVAL_FILTERS = {
'5mins': 605,
'15mins': 60
15,
'30mins': 6030,
'1hour': 60
60,
'5hours': 60605,
'daily': 606024,
'weekly': 'week',
'monthly': 'month'
}

Insert '1min' : 60,

@alvarobartt
Copy link
Owner

Sorry for the delay, will be tackling this today! 👍🏻 I'll generate an updated version of investpy 🔥

@alvarobartt
Copy link
Owner

Hi @fp-repo! The new investpy release is out! 🔥 To install it please use the following command:

pip install investpy --upgrade

Remember to star the repo, follow me here and on Twitter at https://twitter.com/alvarobartt so as to get notified from all the updates and projects I'm working on! ⭐ :octocat:

investpy v1.1.0 automation moved this from To do to Done Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants