Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept float values in financial summary #205

Merged
merged 1 commit into from Sep 26, 2020

Conversation

noelzubin
Copy link
Contributor

No description provided.

@alvarobartt alvarobartt self-requested a review September 26, 2020 10:30
@alvarobartt alvarobartt self-assigned this Sep 26, 2020
@alvarobartt alvarobartt added the minor fix Minor fix or feature label Sep 26, 2020
@alvarobartt
Copy link
Owner

Thank you so much @noelzubin! I will get back to investpy in 1 week or so, as I have been pretty busy, thank you for contributing.

In order to get the latest updates you can follow me on Twitter at https://twitter.com/alvarobartt

@anhanh11001
Copy link

@alvarobartt Hey, any chances we can get this small patch released? Maybe something like v1.0.1

Btw, great package. Thanks a lot for making this open-source

@alvarobartt
Copy link
Owner

Hi @anhanh11001! Thanks for your kind words towards my work with investpy, much appreciated! 🤗 Then regarding this PR, it's already merged on the master branch, later this night I'll create the 1.0.1 as you suggest. But in the meantime you can install the source version with the fix so that you don't run onto this problem again, to do so, please use the following command:

pip install git+https://github.com/alvarobartt/investpy.git@master

Remember to star the repo, follow me here and on Twitter at https://twitter.com/alvarobartt so as to get notified of all the updates and projects I'm working on! ⭐

@anhanh11001
Copy link

It works like a charm 🚀

Thanks for the fast response. In case you need help on improving this lib, I'd like to help with contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor fix Minor fix or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants