Content types #12
Merged
Content types #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the OCCI specification, the accept header MUST be handled as follows: - If Accept is empty, the returned content-type should be text/plain - If Accept is "*/*", the returned content-type should be text/plain - If Accept cannot be understood, a 406 error should be returned. We are still missing the handling of the content-type header (that must indicate the type of the data being sent, if any) that should be checked against the available parsers (this is still missing).
Check that we are actually raising the proper exception when there is a bad request in the compute controller create method.
200, 201 and 202 are valid return codes that will contain a JSON, so we should check for them also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for comments, I will merge this manually