Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-height not working with scrollBar:true and fitToSection:true #1489

Closed
jonasnaimark opened this issue Sep 8, 2015 · 16 comments
Closed

Comments

@jonasnaimark
Copy link

Hello, thanks so much for this plugin it's amazing! I've been trying for a couple of days to get a footer section working but I'm getting some odd behavior I can't fix: http://www.jonasnaimark.com/temp/fullscreentest/Test.html#page12

The page will sometimes auto scroll up one section, other times it will stay but the nav will go back up after a delay. Often when hitting up from the footer it will jump up 2 sections instead of one. Any tips on how to fix this?

Thanks!

@alvarotrigo
Copy link
Owner

It seems to be related with the use of scrollBar:true.
Thanks for reporting it. I'll investigate it.

@alvarotrigo alvarotrigo added the bug label Sep 8, 2015
@alvarotrigo
Copy link
Owner

As a workaround, you can use fitToSection:false to prevent the problem.

alvarotrigo added a commit that referenced this issue Sep 8, 2015
- Fixed bug with fitToSection which stopped working #1465
- Fixed bug with silentMove which stopped working #1476 
- Fixed bug with resizing fullpage.js #1442

Fixed additional bugs:
- Fixed bug smaller sections #1489
- Fixed bug in Firefox when using Ctrl+T to open a new tab #1472 
- Removed unnecessary code #1485
@alvarotrigo
Copy link
Owner

Fixed in fullpage.js 2.7.0

@jonasnaimark
Copy link
Author

Wow thanks for the update! It still seems to be happening on 2.7.0 though if scrollBar:true. Changing fitToSection doesn't fix it either. It works fine if scrollBar:false.

Updated to 2.7.0 with the same bug:
http://www.jonasnaimark.com/temp/fullscreentest/Test.html#page12

@alvarotrigo alvarotrigo reopened this Sep 8, 2015
@alvarotrigo
Copy link
Owner

Right. I'll take a look with more calm for the next release.
However it doesn't seem to be a very simple problem to solve.

@jonasnaimark
Copy link
Author

Thanks again for looking at it!

@alvarotrigo alvarotrigo changed the title Can't get smaller footer section working Auto-height not working when using scrollBar:true Sep 8, 2015
@rootkowski
Copy link

Not sure this will help in your case, but I needed to disable fitToSection on a project but it would still kick in on resize, rotate and sometimes on nav click (the section would be refitted over and over despite autoScrolling and fitToSection set to false). My workaround for that was to set fitToSectionDelay to 3600000 which I believe is one hour in milliseconds. That way the current section doesn't scroll to fill the screen, it stays where you want it, which is very good when you have a lot of content in sections and want to be able to view it all on a phone.

@rootkowski
Copy link

Thanks a lot for the super fast reply! :)
This has definitely fixed it. Tested after removing the delay option.

@jonasnaimark
Copy link
Author

Hi rootkowski, how did you fix it? I don't see the answer posted here. Thanks!

@alvarotrigo
Copy link
Owner

@jojomcbobo

As a workaround, you can use fitToSection:false to prevent the problem.

@jonasnaimark
Copy link
Author

I still seem to have the issue: http://www.jonasnaimark.com/temp/fullscreentest/Test.html#page12

If you scroll to the last page the menu dot will bounce back up sometimes, then if you hit up it will skip a section.

@rootkowski
Copy link

@jojomcbobo Make sure you're using the latest version of fullPage.js (at least 2.7.4).

@jonasnaimark
Copy link
Author

I'm on the latest version and it seems like with scrollbar=true it still doesn't work. Example: http://www.jonasnaimark.com/temp/fullscreentest/Test.html#page12 hit down and it will bounce back up.

@alvarotrigo
Copy link
Owner

@jojomcbobo that's because you have to use fitToSection:false.
Now it works ok with fitToSection:false in the latest 2.7.4.

Demo online

@alvarotrigo alvarotrigo changed the title Auto-height not working when using scrollBar:true Auto-height not working with scrollBar:true and fitToSection:true Oct 14, 2015
This was referenced Dec 15, 2015
@alvarotrigo
Copy link
Owner

Fixed on the development branch 2.7.8

@alvarotrigo
Copy link
Owner

Solved in fullpage.js 2.7.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants