Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fp-viewing not changing with autoScrolling:false and no anchors #2160

Closed
NicolasJEngler opened this issue Jul 18, 2016 · 3 comments
Closed

fp-viewing not changing with autoScrolling:false and no anchors #2160

NicolasJEngler opened this issue Jul 18, 2016 · 3 comments
Labels
bug fixed on dev

Comments

@NicolasJEngler
Copy link

NicolasJEngler commented Jul 18, 2016 •
edited

body's fp-viewing-* class not changing on scroll with autoScrolling set to false

I'm currently using the class Fullpage.js applies to the body when viewing each section (fp-viewing-0, fp-viewing-1, and so on) to trigger CSS animations. While autoScrolling is set to true, this works flawlessly, but as soon as I disable the autoScrolling setting it stops changing the boddy class and it stays on fp-viewing-0

Link to isolated reproduction with no external CSS / JS

Link

Versions

[Chrome 51.0.2704.106, OS X El Capitan 10.11.6, Macbook Air mid 2012]
@alvarotrigo
Copy link
Owner

alvarotrigo commented Jul 18, 2016 •
edited

Thanks for reporting it! That's a bug caused by the lack of anchors.

I'll fix it for the next release. Meanwhile, just use the anchors option or set them up using the attribute data-anchor in each section and slide.

@alvarotrigo alvarotrigo changed the title body's fp-viewing-* class not changing on scroll with autoScrolling set to false body's fp-viewing-* class not changing on scroll with autoScrolling set to false and no anchors Jul 18, 2016
@alvarotrigo alvarotrigo changed the title body's fp-viewing-* class not changing on scroll with autoScrolling set to false and no anchors fp-viewing-* class not changing on scroll with autoScrolling set to false and no anchors Jul 18, 2016
@alvarotrigo alvarotrigo changed the title fp-viewing-* class not changing on scroll with autoScrolling set to false and no anchors fp-viewing class not changing on scroll with autoScrolling set to false and no anchors Jul 18, 2016
@alvarotrigo alvarotrigo changed the title fp-viewing class not changing on scroll with autoScrolling set to false and no anchors fp-viewing not changing on scroll with autoScrolling set to false and no anchors Jul 18, 2016
@alvarotrigo alvarotrigo changed the title fp-viewing not changing on scroll with autoScrolling set to false and no anchors fp-viewing not changing with autoScrolling:false and no anchors Jul 18, 2016
@NicolasJEngler
Copy link
Author

Excellente workaround! Thank you so much.

alvarotrigo added a commit that referenced this issue Aug 15, 2016
@alvarotrigo
- Fixed bug: state class didnt change when using autoScrolling:false …
7751b26 
…and no anchors #2160
@alvarotrigo alvarotrigo mentioned this issue Aug 15, 2016
Merged
@alvarotrigo
Copy link
Owner

Fixed in fullpage.js 2.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed on dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvarotrigo @NicolasJEngler