Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Overflow Scroll Bars Visible on Responsive Mode Activated #4448

Closed
meceware opened this issue Aug 21, 2022 · 4 comments
Closed

Scroll Overflow Scroll Bars Visible on Responsive Mode Activated #4448

meceware opened this issue Aug 21, 2022 · 4 comments

Comments

@meceware
Copy link

Hi,

When responsive mode is activated, the scroll bar position is still active hence shifts the content left a little bit. However the scroll bars are not visible anymore.

https://codepen.io/meceware/pen/OJvqPer

Thanks,

@alvarotrigo
Copy link
Owner

Hey Mehmet!

Thanks for that!
I was able to reproduce the issue on Windows.

I guess the question here is, what do we do with sections using ScrollOverflow in responsive mode.

Right now, the issue will got away if you apply the class fp-auto-height-responsive.

Perhaps we should, by default, turn all scrollable sections into "auto height sections" on responsive by adding this class for them?
fullPage.js v3 didn't even deal with this issue at all and would break when not applying fp-auto-height-responsive.
https://codepen.io/alvarotrigo/pen/eYMopWV

@meceware
Copy link
Author

by default, turn all scrollable sections into "auto height sections" on responsive

Thank you, I think it definitely makes more sense than double scrollable section.

@alvarotrigo
Copy link
Owner

Reproduction of the issue with 4.0.10:
https://codepen.io/alvarotrigo/pen/BarEorL?editors=1010

The issue is now fixed on the dev branch.
The issue was related with #4447

ScrollOverflow sections will turn into auto-height sections on responsive. Therefore they won't contain any styling for scrollOverflow sections, which was the issue in this case.

alvarotrigo added a commit that referenced this issue Sep 6, 2022
…4447

- Enhancement: dynamically adding content will automatically create scrollable elements when using scrollOverflow: true.
@alvarotrigo
Copy link
Owner

Fixed in fullPage.js 4.0.11 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants