Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the <summary> element to focussable elements constant. #4556

Merged
merged 7 commits into from Jun 13, 2023

Conversation

JayBox325
Copy link
Contributor

Adding the summary HTML element to the focusable elements constant.

Building an application using the Gov.uk Design System and found a bug where the Details component wasn't focussable.

https://design-system.service.gov.uk/components/details/

  1. Make sure to commit it to the dev branch!
  2. Read https://github.com/alvarotrigo/fullPage.js/wiki/Contributing-to-fullpage.js

alvarotrigo and others added 7 commits November 22, 2022 20:02
Adding the summary HTML element to the focusable elements constant.

Building an application using the Gov.uk Design System and found a bug where the Details component wasn't focussable.

https://design-system.service.gov.uk/components/details/
@JayBox325 JayBox325 changed the title Update constants.js Added the <summary> component to focussable elements constant. Jun 13, 2023
@JayBox325 JayBox325 changed the title Added the <summary> component to focussable elements constant. Added the <summary> element to focussable elements constant. Jun 13, 2023
@alvarotrigo alvarotrigo changed the base branch from master to dev June 13, 2023 14:49
@alvarotrigo
Copy link
Owner

Awesome, thanks for that!
I appreciate it! 👍

@alvarotrigo alvarotrigo merged commit 3a26592 into alvarotrigo:dev Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants