-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added slimScroll default and extending options #612
Conversation
No globals options as for fullPage.js, but Please take a look at http://rocha.la/jQuery-slimScroll, You could try to add some prop to window and encapsulate fullpage.js something like
and give it to fullpage like
here are the full settings offslimScroll :
|
fullPage.js might change to iScroll.js. |
I know this is a hack, but I worked around it like so:
|
This update adds a new option called 'scrollOverflowHandler' which consolidates all code related to scrollOverflow and allows it to be swapped out with different functionality. By default, it will use the existing jquery.slimScroll handling of scroll overflow. This should make it easier for users to either customize the slimScroll handling or replace it with other code just as wrapping content in a div with `overflow: scroll` or utilizing iscroll.js as requested in issues alvarotrigo#506, alvarotrigo#612 and others.
This update adds a new option called 'scrollOverflowHandler' which consolidates all code related to scrollOverflow and allows it to be swapped out with different functionality. By default, it will use the existing jquery.slimScroll handling of scroll overflow. This should make it easier for users to either customize the slimScroll handling or replace it with other code just as wrapping content in a div with `overflow: scroll` or utilizing iscroll.js as requested in issues alvarotrigo#506, alvarotrigo#612 and others.
This update adds a new option called 'scrollOverflowHandler' which consolidates all code related to scrollOverflow and allows it to be swapped out with different functionality. By default, it will use the existing jquery.slimScroll handling of scroll overflow. This should make it easier for users to either customize the slimScroll handling or replace it with other code just as wrapping content in a div with `overflow: scroll` or utilizing iscroll.js as requested in issues alvarotrigo#506, alvarotrigo#612 and others.
For the time being the "hack" of @andremalkine is just great! |
@Kwaadpepper, would you consider updating your fullpage.js version so I can merge your PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job:)
@TeAmP0is0N @rodrigozamb why are you guys even commenting on a topic that is from 2014 and that was closed in 2016? |
Hey @alvarotrigo, I'm going to wager the same reason I ended up here just now. Via it being the top link on http://www.pullrequestroulette.com/ |
@jodylecompte that's quite weird. This pull request has been closed since 2016... while there are many others open and those won't appear on that page? |
Slimscroll options to make fullpage more usable