Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navigation dots #817

Closed
wants to merge 1 commit into from
Closed

Improve navigation dots #817

wants to merge 1 commit into from

Conversation

jacobmllr95
Copy link
Contributor

No description provided.

@alvarotrigo
Copy link
Owner

What's the improvement? With so many style corrections I can not see the real changes...

@alvarotrigo alvarotrigo closed this Nov 7, 2014
@jacobmllr95
Copy link
Contributor Author

  1. Unneeded margins are removed from the dot's so they are perfectly aligned
  2. The selectors are better defined to avoid troubles when adding additional elements (like navigation arrows) to the navigation. Example: #fp-nav span => #fp-nav ul li a span

@alvarotrigo
Copy link
Owner

Unneeded margins are removed from the dot's so they are perfectly aligned

Currently they are also aligned, the only difference I can see with your code is that they have less margin to the right.

Yours vs Current

The selectors are better defined to avoid troubles when adding additional elements (like navigation arrows) to the navigation. Example: #fp-nav span => #fp-nav ul li a span

That's ok, but if you want me to merge the changes then you will have to remove all the style changes and just keep the real ones.

@jacobmllr95
Copy link
Contributor Author

This #820 should be finde for you now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants