Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The terminal icon looks bad with Nordic-darker and XFCE #78

Closed
hacker-hackman opened this issue Sep 23, 2022 · 9 comments
Closed

The terminal icon looks bad with Nordic-darker and XFCE #78

hacker-hackman opened this issue Sep 23, 2022 · 9 comments

Comments

@hacker-hackman
Copy link

hacker-hackman commented Sep 23, 2022

Hi, alvatip!
I really appreciate your work. I'm new in Linux and your icon theme and Nordic made me stop theme hopping :)

I'm using 1366x768 screen, Nordic-darker theme and XFCE

My issue in the first place is that the terminal icon on panel looks little weird. Like someone cut it carelessly from somewhere using Photoshop. It's because of white rim around the terminal's logo. I know it's not your fault, it goes from parent WhiteSur icon theme.

Screenshot_2022-09-23_20-16-28

Secondly the icon looks blurred at window's title

Screenshot_2022-09-23_20-19-56

@hacker-hackman hacker-hackman changed the title The terminal icon looks bad with Nordic-dark and XFCE The terminal icon looks bad with Nordic-darker and XFCE Sep 23, 2022
@MolassesLover
Copy link
Contributor

This is likely because of the backdrop being coloured with #2e3440.
I made issue #71 for this reason.

@alvatip
Copy link
Owner

alvatip commented Sep 25, 2022

Hi @hacker-biba ! Thanks for reporting this.
For the first issue, this might be fixed with #71, but I mainly think that the white border is too thin... I will also try to either resize it, or re-design the icon, so this issue does not appear any more.
For the second issue, I will have to dig a little bit more since all icons are scalable svg, so this should not happen (well at least to my knowledge)
I will work on this issue as soon as the 2 previous are fixed (should be soon, we are getting very close to a solution) 😉

@alvatip
Copy link
Owner

alvatip commented Oct 2, 2022

@hacker-biba, I redesigned the terminal icon, this should fix the first issue 😉 Could you try the new one and tell me if it looks fine ? also does the second issue still appear ?
Thanks!

@MolassesLover
Copy link
Contributor

@hacker-biba, I redesigned the terminal icon, this should fix the first issue wink Could you try the new one and tell me if it looks fine ? also does the second issue still appear ? Thanks!

It reads so much worse on Nordic GTK, or a desktop with a Nord background.I really like the style but it just doesn't suit the Nord ecosystem. Do you think you could add the outline back in?

@alvatip
Copy link
Owner

alvatip commented Oct 2, 2022

I will look for another solution with the White border then 😉

@MolassesLover
Copy link
Contributor

MolassesLover commented Oct 2, 2022

Awesome, take your time, and thanks for all the good work!

@alvatip
Copy link
Owner

alvatip commented Oct 5, 2022

I modified the terminal icon, giving it a thicker border to avoid this weird look like it was cut in photoshop and keeping the white border. This is a first try, so the size of the border and the symbol inside the icon might still have to be adjusted.

Another solution could be the removal of the white border and inversion of the colors (so white background and black symbol) but when I think of terminal icon, dark is the primary color that pops in my mind haha

Tell me what you think!

Thanks 😉

@alvatip alvatip closed this as completed Oct 18, 2022
@hacker-hackman
Copy link
Author

@alvatip,
The icon looks great
Screenshot_2022-11-17_10-51-24
Screenshot_2022-11-17_10-52-00
Untitled

Thanks!

@alvatip
Copy link
Owner

alvatip commented Nov 17, 2022

Good news!
Thanks for confirming that it looks fine ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants