Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure universal wheels #5

Merged
merged 2 commits into from Aug 7, 2017
Merged

Configure universal wheels #5

merged 2 commits into from Aug 7, 2017

Conversation

graingert
Copy link
Contributor

No description provided.

@alvinlindstam
Copy link
Owner

Thanks, I haven't paid much attention to the packaging of the project.

This project is currently Python 3 only. If I'm not mistaken, the universal flag should be used for packages that support bort Python 2 and 3, right? If it shouldn't be an universal wheel, should we do anything else than using python setup.py sdist bdist_wheel upload instead of python setup.py sdist upload when releasing?

@graingert
Copy link
Contributor Author

@alvinlindstam yeah pretty much

@alvinlindstam alvinlindstam merged commit 870b32f into alvinlindstam:master Aug 7, 2017
alvinlindstam added a commit that referenced this pull request Aug 7, 2017
@alvinlindstam
Revert "Merge pull request #5 from graingert/patch-1"
736682f 
This reverts commit 870b32f, reversing
changes made to be6e9d6.

Defining py3=1 in setup.cfg gave the error:

running bdist_wheel
error: error in setup.cfg: command 'bdist_wheel' has no such option 'py3'
@alvinlindstam
Copy link
Owner

Thanks, @graingert. I have uploaded a py3 wheel for the project to pypi now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @alvinlindstam