Windows: Remove SkipAUD from AMF code #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deiteris
force-pushed
the
remove-skipaud
branch
from
b9b8b72
to
938d66e
Compare
|
SkipAUD is no longer required since it will the be part of ClientConnection implemented in #1403. |
|
Can be merged, since related PR was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to keep it was buggy handling of AUD insertion in H.264 by older AMD drivers (22.3.1 and prior), and for H.265 for very old drivers. But since #1227,
AMF_VIDEO_ENCODER_INSERT_AUDandAMF_VIDEO_ENCODER_HEVC_INSERT_AUDwere enabled for encoder and the issue was gone. I think this code can be safely removed.