Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard and settings minor rehearsal #1893

Merged
merged 21 commits into from Nov 14, 2023

Conversation

Meister1593
Copy link
Collaborator

@Meister1593 Meister1593 commented Nov 7, 2023

Added Setup page for enabling hand tracking gestures toggle
Added Donate to Open Collective hyperlink in About tab
Updated setup page with software requirements (added linux audio auto setup)
Updated wiki page for hand tracking gestures, distrobox guide.
Updated default sharpening to 0.5 (significantly improves quality for basically free)
Removed Dynamic oculus foveation toggle (was completely unused in codebase, was replaced with client foveation options)

@Meister1593
Copy link
Collaborator Author

image
image

Some labels are subject to be changed, i just laid it as is for now, feel free anyone to suggest better ones.

@zarik5
Copy link
Member

zarik5 commented Nov 7, 2023

Could you split this PR into one for each feature? or at least move the foveated encoding refactor to another PR as it's dominating regarding the number of changes.

@Meister1593 Meister1593 force-pushed the dashboard_rehearsal branch 2 times, most recently from 669e145 to 563c978 Compare November 7, 2023 07:50
@Meister1593
Copy link
Collaborator Author

Could you split this PR into one for each feature? or at least move the foveated encoding refactor to another PR as it's dominating regarding the number of changes.

Done #1894

@zarik5
Copy link
Member

zarik5 commented Nov 7, 2023

LGTM 👍

@Vixea
Copy link
Collaborator

Vixea commented Nov 7, 2023

Actually I just noticed something disable adaptive framerate not sure how I feel about that one as it should've been fixed, so is not needed

@zarik5 zarik5 force-pushed the master branch 2 times, most recently from 9644be2 to 92e4791 Compare November 8, 2023 11:43
@Meister1593 Meister1593 force-pushed the dashboard_rehearsal branch 2 times, most recently from 2f2e748 to e9058bd Compare November 13, 2023 08:58
@Meister1593
Copy link
Collaborator Author

Actually I just noticed something disable adaptive framerate not sure how I feel about that one as it should've been fixed, so is not needed

i reverted that change, it didn't seem to affect it anymore. I'm not 100% certain if it's completely fixed on high bitrate cabled, but i couldn't test that anyway on master, so i would leave it as is for now.

@Meister1593
Copy link
Collaborator Author

I'm going to clean up a bit with platform-specific checks (clippy complains) and i think it will be done

@Vixea
Copy link
Collaborator

Vixea commented Nov 13, 2023

Also looks like the unix module import needs to be cfg guarded

alvr/dashboard/Cargo.toml Outdated Show resolved Hide resolved
alvr/dashboard/src/dashboard/components/setup_wizard.rs Outdated Show resolved Hide resolved
@Meister1593
Copy link
Collaborator Author

Question, should i consider all the platform checks/stuff for macos as well? (like, right now it will show vb cable for windows on macos)

@Meister1593
Copy link
Collaborator Author

Question, should i consider all the platform checks/stuff for macos as well? (like, right now it will show vb cable for windows on macos)

nevermind, i need to do them anyway otherwise it won't even build on macos

Copy link
Member

@zarik5 zarik5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and remove whitespaces at line 4 and 10 😅

@zarik5 zarik5 merged commit aaeecf5 into alvr-org:master Nov 14, 2023
6 checks passed
@Malthasa
Copy link

Malthasa commented Dec 8, 2023

hey, here from the stable version. For some reason, pipewire doesn't show up in my audio options. I am on manjaro linux, and i have pipewire installed.

@Meister1593
Copy link
Collaborator Author

hey, here from the stable version. For some reason, pipewire doesn't show up in my audio options. I am on manjaro linux, and i have pipewire installed.

This PR is unrelated to any audio options, i would create separate issue for this instead of writing here.

@Malthasa
Copy link

Malthasa commented Dec 8, 2023

oops sorry

@Meister1593 Meister1593 deleted the dashboard_rehearsal branch April 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants