Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AV1 support #1955

Merged
merged 7 commits into from Jan 14, 2024
Merged

Enable AV1 support #1955

merged 7 commits into from Jan 14, 2024

Conversation

wsippel
Copy link
Contributor

@wsippel wsippel commented Jan 12, 2024

Add AV1 support to the client and enable AV1 VA-API encoding on Linux. Tested on a Radeon 7900XTX GPU and Quest 3.

@zarik5
Copy link
Member

zarik5 commented Jan 13, 2024

You need to rebase this PR and fix the CI checks

@wsippel
Copy link
Contributor Author

wsippel commented Jan 13, 2024

I hope I rebased this correctly. I also don't get the failed check. Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration looks like a problem with the CI itself, no? And the three warnings the check spits out are all in files this PR doesn't touch.

@zarik5
Copy link
Member

zarik5 commented Jan 13, 2024

Uhm I think you didn't rebase correctly. The amount of changes doesn't correspond to the actual changes. To see the actual error in CI you need to expand the section.

@wsippel
Copy link
Contributor Author

wsippel commented Jan 13, 2024

How can that even happen? I just followed a guide I found online and did:

git remote add upstream https://github.com/alvr-org/ALVR.git
git fetch upstream
git rebase upstream/master
git push origin master --force

@zarik5
Copy link
Member

zarik5 commented Jan 14, 2024

Oh sorry, nevermind. the large change is for the av1 backport patch for ffmpeg, I missed that at first. so LGTM :)

@zarik5 zarik5 merged commit 5c4d263 into alvr-org:master Jan 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants