Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing aux bones in hand skeleton #2009

Merged
merged 3 commits into from Feb 29, 2024

Conversation

shinyquagsire23
Copy link
Contributor

Indices 26-30 are used for the auxiliary bones, and were uninitialized before. This fixes not being able to press the button at the start of The Lab with the Index/robot hands.

Currently I'm not setting the orientation, because I wasn't sure how to accumulate the quaternions.

Copy link
Member

@zarik5 zarik5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, thanks. Good also for refactoring the wrist bones code :) Needs just a cargo fmt and good to go.

@zarik5 zarik5 merged commit 421480d into alvr-org:master Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants