Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): 🐛 Enable GPL on linux build and remove AppImage from CI #2056

Merged
merged 1 commit into from Apr 5, 2024

Conversation

Meister1593
Copy link
Collaborator

Same deal as on nightlies

Merge only after it gets tested at least on nightlies, otherwise i don't know if it works on nvidia (double-checking removal of nc-codec-headers)

@Meister1593 Meister1593 requested a review from zarik5 April 1, 2024 13:17
@Meister1593 Meister1593 changed the title feat(xtask): 🐛 Enable GPL on linux build and remove AppImage from CI fix(ci): 🐛 Enable GPL on linux build and remove AppImage from CI Apr 1, 2024
@Meister1593
Copy link
Collaborator Author

...theres literally no code change, and it ran just fine before i change commit name

ignore macos check?...
image

@zarik5
Copy link
Member

zarik5 commented Apr 1, 2024

Yeah it likes to fail on alvr_packets for some reason

@zarik5 zarik5 merged commit a0fe143 into alvr-org:master Apr 5, 2024
5 of 6 checks passed
@MadByteDE
Copy link

Sry for asking but why removing AppImages? They worked just fine for me on nvidia.

@PassiveLemon
Copy link

I'm interested in why as well.

@Meister1593
Copy link
Collaborator Author

AppImages weren't required anymore (almost everything is bundled into alvr as static library now, appimage reason for being portable is nulled at this point) and it was maintenance burden that no one knew how to properly maintain, thus it was removed as unnecessary.

@Meister1593 Meister1593 deleted the pipelines-gpl-no-appimage branch April 6, 2024 14:35
@AnOpenSauceDev AnOpenSauceDev mentioned this pull request Apr 12, 2024
5 tasks
@guysoft
Copy link

guysoft commented Apr 12, 2024

Hey, so I am trying to run the linux build and its crashing. I am not sure why, but this did not happen with the appimage. Is there a way to figure what is missing in the native build?

@Meister1593
Copy link
Collaborator Author

Meister1593 commented Apr 12, 2024

@guysoft please open new issue and provide output of ldd bin/alvr_dashboard and lib64/alvr/bin/linux64/driver_alvr_server.so with it
as well as system and other information of course

@mAd-DaWg
Copy link

@Meister1593 for the same reason please remove flatpack, as the exact same logic applies

@Meister1593
Copy link
Collaborator Author

Flatpak is made fairly differently but removing flatpak build is planned as well. Just need to update instructions how to use with tar instead of it. It might be also possible to use it with nvidia that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants