Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove new dashboard #679

Merged
merged 4 commits into from
May 28, 2021
Merged

Remove new dashboard #679

merged 4 commits into from
May 28, 2021

Conversation

zarik5
Copy link
Member

@zarik5 zarik5 commented May 23, 2021

Revert settings-schema to old version

Revert settings-schema to old version
@zarik5 zarik5 requested a review from xytovl May 23, 2021 22:28
@xytovl
Copy link
Collaborator

xytovl commented May 24, 2021

Fails to build for me thread 'main' panicked at 'called Result::unwrap()on anErr value: Error { kind: NotFound, message: "No such file or directory (os error 2)" }', alvr/xtask/src/main.rs:232:89

    let dir_content =
        dirx::get_dir_content2("alvr/legacy_dashboard", &dirx::DirOptions { depth: 1 }).unwrap();
    let items: Vec<&String> = dir_content.directories[1..]
        .iter()
        .chain(dir_content.files.iter())
        .collect();

@zarik5
Copy link
Member Author

zarik5 commented May 24, 2021

I corrected it before but I forgot to do it again in the merge commit.

Copy link
Collaborator

@xytovl xytovl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and launches fine, I didn't go through all the changes but seems all fine

@zarik5 zarik5 merged commit 455ba3a into alvr-org:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants