-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS&JS formatting #737
Conversation
36ed01e
to
cc08677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a prettier.rc file, since different people can have a different configuration default. Also prettier.rc should be configured to keep the formatting a s close to the original code as possible (for example use 4 spaces indentation). You can pick the prettier.rc file in the new-dashboard branch.
Wrong:
I chose to not do that to avoid the inevitable configuration fight and with the Also, if we are moving away from the defaults I'd like to bring your attention to why tabs are important |
Ended up using 4 spaces after a discussion on Discord. Merging. |
This PR adds:
xtask
subcommand to run prettier, pinned to the aforementioned Action's version.