-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Packaging #738
Merged
Merged
Add Packaging #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckiee
requested changes
Jul 18, 2021
ckiee
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit sleepy right now but it looks mostly good, just nitpicks.
ckiee
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the actual rpm
but source looks good now.
- Added freedesktop desktop file for Gnome / KDE - Updated specfile %post code
- Ignored errors about existing port labels (we don't care)
- Updated license - Added trailing newlines - Removed path from executable in freedesktop config
zarik5
pushed a commit
that referenced
this pull request
Jul 25, 2021
* initial specfile based on safestore * more specfile updates * final touches to the specfile without SELinux * removed snapd stuff in favor of repo * removed snapd stuff in favor of repo * added firewalld and initial SELinux policy * fixed unfinished path * Added comments and specfile improvements * more work on policy and firewall * fixed semanage, and removed exec_bin for selinux * - Moved nixOS to packaging directory - Added freedesktop desktop file for Gnome / KDE - Updated specfile %post code * - Added png generation and png code - Ignored errors about existing port labels (we don't care) * updated specfile * Added conditional logic for port labeling * - Updated descriptions - Updated license - Added trailing newlines - Removed path from executable in freedesktop config * Added `bump_spec_version()` to xtask * Updated firewalld service description * Removed hard dependency on rpmfusion * Updated source and changelog for rpmlint * Set release to 1.0.0 since this is the production release version * removed unneeded changelog entry * Maybe the extra space broke the CI? * Made function name more descriptive * used crate::workspace_dir * Added code to set the release to production (1.0.0) on new versions * added space * nix: update patch url * rpm: bump to 16.0.0 Co-authored-by: ckie <git-525ff67@ckie.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
alvr
service for UDP/9943-9944.spec
file for Fedora 34+alvr
confined to ports UDP/9943-9944desktop
file for Gnome / KDE application menu