Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Packaging #738

Merged
merged 28 commits into from
Jul 23, 2021
Merged

Add Packaging #738

merged 28 commits into from
Jul 23, 2021

Conversation

Trae32566
Copy link
Collaborator

This adds:

  • Firewalld alvr service for UDP/9943-9944
  • RPM .spec file for Fedora 34+
  • SELinux policy alvr confined to ports UDP/9943-9944
  • FreeDesktop desktop file for Gnome / KDE application menu
  • Moved NixOS package config to packages/nix

packaging/rpm/alvr.spec Outdated Show resolved Hide resolved
packaging/freedesktop/alvr.desktop Outdated Show resolved Hide resolved
packaging/rpm/alvr.spec Outdated Show resolved Hide resolved
packaging/rpm/alvr.spec Outdated Show resolved Hide resolved
packaging/rpm/alvr.spec Outdated Show resolved Hide resolved
packaging/rpm/alvr.spec Outdated Show resolved Hide resolved
@Trae32566 Trae32566 requested a review from ckiee July 18, 2021 22:13
Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit sleepy right now but it looks mostly good, just nitpicks.

alvr/xtask/src/version.rs Outdated Show resolved Hide resolved
alvr/xtask/src/version.rs Outdated Show resolved Hide resolved
Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the actual rpm but source looks good now.

@ckiee ckiee added this to the v16 milestone Jul 22, 2021
@ckiee ckiee merged commit d8931cd into alvr-org:master Jul 23, 2021
zarik5 pushed a commit that referenced this pull request Jul 25, 2021
* initial specfile based on safestore

* more specfile updates

* final touches to the specfile without SELinux

* removed snapd stuff in favor of repo

* removed snapd stuff in favor of repo

* added firewalld and initial SELinux policy

* fixed unfinished path

* Added comments and specfile improvements

* more work on policy and firewall

* fixed semanage, and removed exec_bin for selinux

* - Moved nixOS to packaging directory
- Added freedesktop desktop file for Gnome / KDE
- Updated specfile %post code

* - Added png generation and png code
- Ignored errors about existing port labels (we don't care)

* updated specfile

* Added conditional logic for port labeling

* - Updated descriptions
    - Updated license
    - Added trailing newlines
    - Removed path from executable in freedesktop config

* Added `bump_spec_version()` to xtask

* Updated firewalld service description

* Removed hard dependency on rpmfusion

* Updated source and changelog for rpmlint

* Set release to 1.0.0 since this is the production release version

* removed unneeded changelog entry

* Maybe the extra space broke the CI?

* Made function name more descriptive

* used crate::workspace_dir

* Added code to set the release to production (1.0.0) on new versions

* added space

* nix: update patch url

* rpm: bump to 16.0.0

Co-authored-by: ckie <git-525ff67@ckie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants