Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 19? #29

Closed
emartynov opened this issue Nov 9, 2023 · 5 comments
Closed

JDK 19? #29

emartynov opened this issue Nov 9, 2023 · 5 comments

Comments

@emartynov
Copy link

I was at Droidcon UK, and there was mention that an upgrade to JDK 19 makes a noticeable build improvement.
Do you have any plans for JDK 19?

I'm also kind of person who usually uses the latest JDK possible - Do you have thoughts about pointing the latest image to the latest JDK?

@G00fY2
Copy link

G00fY2 commented Nov 10, 2023

My opinion: Latest Android Studio is shipping JDK 17 too. Also people usually tend to use LTS JDK versions on Android. This would be JDK 21 which will be supported with AGP 8.3.0-alpha03 and newer: https://issuetracker.google.com/issues/294137077

This also requires Gradle 8.5+ which is currently RC.

JDK 19 sounds a bit random to me. I would expect a new JDK flavor with Java 21 LTS as soon as AGP 8.3 and Gradle 8.5 went stable.

@emartynov Were you able to see noticeable faster builds locally?

@emartynov
Copy link
Author

@G00fY2 I don't have any proper infrastructure in my build to measure speed improvement for the build times. However, Hinge dev team has it.

Slack team is on JDK 20.
Square team is on JDK 20 also.

JDK 19 is not random for me.

And, I don't write any Java code the LTS for me is not important and I believe Gradle, AGP and KGP just catch up as soon as possible.

However, let's wait if the community/users of these docker images would ask for such a change as well.

I still would appreciate having an experimental image with everything latest in it.

@G00fY2
Copy link

G00fY2 commented Nov 10, 2023

JDK 19 is not random for me.

I meant random in that sense that is neither the latest available version (JDK 21), nor the latest version that can be used to build with current stable AGP 8.1 (JDK 20).

And, I don't write any Java code the LTS for me is not important and I believe Gradle, AGP and KGP just catch up as soon as possible.

I know that you can use newer JDK versions.
But at least Google jumped in their docs and their embedded JDK by the LTS versions:

  • pre Android Studio 4.2 JDK 8
  • Android Studio 4.2+ JDK 11
  • Android Studio Flamingo+ JDK 17

PS: Generally I like the idea of experimental images. But then it could be confusing what "latest" should point to. The lastest default JDK or the latest "experimental" one?

@G00fY2
Copy link

G00fY2 commented Jan 4, 2024

Btw AGP 8.2.1 was released wich added a fix to work with JDK 21 LTS.

alvr added a commit that referenced this issue Jan 5, 2024
* Add JDK19 and JDK21 #29
* Android 34 (Upside-down Cake) is now `latest` #14
alvr added a commit that referenced this issue Jan 5, 2024
* Add JDK19 and JDK21 #29
* Android 34 (Upside-down Cake) is now `latest` #14
alvr added a commit that referenced this issue Jan 5, 2024
* Add JDK21 #29
* Android 34 (Upside-down Cake) is now `latest` #14
@alvr
Copy link
Owner

alvr commented Jan 5, 2024

JDK21 support is added in v2024.01.05. I skipped JDK19 because is EOL.

@alvr alvr closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants