Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link visibility in posts #18

Closed
vinnymac opened this issue Nov 23, 2016 · 1 comment
Closed

Link visibility in posts #18

vinnymac opened this issue Nov 23, 2016 · 1 comment

Comments

@vinnymac
Copy link
Contributor

vinnymac commented Nov 23, 2016

Summary

I noticed that anchor tags in posts had pretty much all styling stripped. I added the below styling to the anchors in posts so that they would become visible. Was this styling intentional? Seeing as the other links for the pages and read full posts are very obvious I assumed this was a bug.

For an example look at the wikipedia link on the demo site here.

If this isn't a bug, I apologize for creating more noise.

Potential Fix

.blog-single .text a:active, a:hover {
	outline: 0;
}
.blog-single .text a:active {
	color: #6a5dff;
}
.blog-single .text a:hover {
	border-bottom: 1px solid;
	color: #427ef7;
}

Example of Fix

screen shot 2016-11-23 at 4 57 41 pm

Additional

Currently anchors also replace the current page because they don't use target='_blank'. If you would like it I can easily add this behavior to lumen so it happens automatically for links in posts.

@vinnymac vinnymac changed the title Links in posts Link visibility in posts Nov 23, 2016
@alxshelepenok
Copy link
Owner

I noticed that anchor tags in posts had pretty much all styling stripped. I added the below styling to the anchors in posts so that they would become visible. Was this styling intentional? Seeing as the other links for the pages and read full posts are very obvious I assumed this was a bug.

Thank you for notice this error.

I think, All you need to do is change color of a links:
Default: #5d93ff
Hover, Focus: #f7a046

If you have time to fix it, then it will be great. But in any case it will be fixed.

Currently anchors also replace the current page because they don't use target='_blank'. If you would like it I can easily add this behavior to lumen so it happens automatically for links in posts.

Good. To do this, need to override the Markdown Loader, is not it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants