Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Flow typing #178

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Integrate Flow typing #178

merged 1 commit into from
Apr 10, 2019

Conversation

vzhou842
Copy link
Collaborator

@vzhou842 vzhou842 commented Apr 8, 2019

Description

Integrates Flow.

  • Installs gatsby-plugin-flow, the official Gatsby plugin for Flow
  • Installs flow-bin and @babel/plugin-transform-flow-strip-types as dev dependencies
  • Adds flow type check to the lint script
  • Adds '@babel/plugin-transform-flow-strip-types' to jest-preprocess so Jest tests still work
  • Updates README
  • Adds /src/flow/CSSModuleStub.js so that Flow ignores CSS module imports. This is the standard way to do this.
  • Adds Flow typing to Sidebar.js and index-template.js as an initial test to show that Flow works.

Related Issues

Discussed in #176.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #178   +/-   ##
======================================
  Coverage    95.1%   95.1%           
======================================
  Files          28      28           
  Lines         143     143           
  Branches        8       8           
======================================
  Hits          136     136           
  Misses          7       7
Impacted Files Coverage Δ
src/templates/index-template.js 100% <100%> (ø) ⬆️
src/components/Sidebar/Sidebar.js 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635bf9c...e62c37d. Read the comment docs.

@alxshelepenok
Copy link
Owner

@vzhou842 thanks for the contribution!

@alxshelepenok alxshelepenok merged commit f48a821 into alxshelepenok:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants