Refactor the React logic and introduce Fragment #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why Codacy keeps telling me there should be a new line... The problem should have been fixed in my 4485418, and it looks good on my local machine with ESLint. I even added an extra line but it does not help... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragmentof GraphGL from Sidebar and reuse it in the templates. Previously they're all copy-pasted, which makes making changes very hard...) used in the Templates. The nested element usually does not need all the information that the parent component requested. Pass the required information by React property by hand instead of just use spread syntax make the code easier to read and understand what is actually used