Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed .gatsby-highlight selectors #89

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

vzhou842
Copy link
Collaborator

@vzhou842 vzhou842 commented Feb 4, 2019

The .gatsby-highlight selectors don't do anything because it doesn't have a :global() qualifier. The CSS styles aren't applied because the class gets changed from gatsby-highlight to something else due to CSS Modules:

screen shot 2019-02-04 at 5 38 57 pm

If you wrap them in :global() qualifiers it works, but the styles seem to not be helpful - they make the prism.js code block off center. Since the selectors weren't doing anything to begin with, I've just removed them in this PR since they're dead code.

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          28       28           
  Lines         140      140           
  Branches        8        8           
=======================================
  Hits          134      134           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d01bb...3e9a1a4. Read the comment docs.

@alxshelepenok alxshelepenok merged commit 34f59f5 into alxshelepenok:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants