refactor(*): remove unnecessary annotations

Remove ngInject annotations; general housekeeping.

Closes fgpv-vpgf#39

src/app/common/router/statehelper.js

@@ -42,7 +42,6 @@
     }
 
     // TODO: add routing error handling
-    /* @ngInject */
     function statehelper(statehelperConfig) {
         var $stateProvider = statehelperConfig.config.$stateProvider;
 

src/app/core/common.service.js

@@ -16,7 +16,6 @@
         .factory('common', common);
 
     // TODO: add helper function to common
-    /* @ngInject */
     function common($timeout) {
         var service = {
             $timeout: $timeout

src/app/core/config.service.js

@@ -38,12 +38,11 @@
         .module('app.core')
         .factory('configService', configService);
 
-    /* @ngInject */
     function configService($q, $rootElement, $timeout, $http, configDefaults) {
-        var initializePromise;
-        var isInitialized = false;
+        let initializePromise;
+        let isInitialized = false;
 
-        var service = {
+        const service = {
             data: {},
             initialize: initialize,
             ready: ready
@@ -63,8 +62,8 @@
 
             // store the promise and return it on all future calls; this way initialize can be called one time only
             initializePromise = $q(function (fulfill, reject) {
-                var configAttr = $rootElement.attr('th-config');
-                var configJson;
+                const configAttr = $rootElement.attr('th-config');
+                let configJson;
 
                 // This function can only be called once.
                 if (isInitialized) {

src/app/core/core.config.js

@@ -1,5 +1,4 @@
 (() => {
-    'use strict';
 
     /**
      * @ngdoc function
@@ -18,7 +17,6 @@
 
     function configBlock($translateProvider, $stateProvider,
         $mdThemingProvider, $mdIconProvider, statehelperConfigProvider) {
-        'ngInject';
 
         configureStateRouting();
         configureTranslations();

src/app/layout/filters-panel-plug.controller.js

@@ -16,7 +16,6 @@
         .controller('FiltersPanelPlugController', FiltersPanelPlugController);
 
     function FiltersPanelPlugController($rootScope, $state) {
-        'ngInject';
         const self = this;
         self.active = true;
         self.mode = 'default';

src/app/layout/layout.route.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -13,7 +12,6 @@
         .module('app.layout')
         .run(layoutConfig);
 
-    /* @ngInject */
     /**
      * Sets initial application routes.
      * some info: https://github.com/angular-ui/ui-router/wiki/Nested-States-and-Nested-Views

src/app/layout/layout.service.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc service
@@ -13,9 +12,8 @@
         .module('app.layout')
         .factory('layoutService', layoutService);
 
-    /* @ngInject */
     function layoutService(sideNavigationService, mapNavigationService) {
-        var service = {
+        const service = {
             sidenav: sideNavigationService,
             mapnav: mapNavigationService
         };

src/app/layout/main-panel-plug.controller.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -14,7 +13,6 @@
         .module('app.layout')
         .controller('MainPanelPlugController', MainPanelPlugController);
 
-    /* @ngInject */
     function MainPanelPlugController($rootScope) {
         const self = this;
         self.active = true;

src/app/layout/side-panel-plug.controller.js

@@ -14,7 +14,6 @@
         .controller('SidePanelPlugController', SidePanelPlugController);
 
     function SidePanelPlugController($state) {
-        'ngInject';
         const self = this;
 
         self.active = true;

src/app/ui/appbar/appbar.controller.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -14,15 +13,14 @@
         .module('app.ui.appbar')
         .controller('AppbarController', AppbarController);
 
-    /* @ngInject */
     /**
      * `AppbarController` has lots of garbage code so far, needed to show how the panels are toggled. It should be moved to service.
      *
      * @param {object} layoutService
      * @param {object} $state
      */
     function AppbarController(layoutService, $state) {
-        var self = this;
+        const self = this;
 
         self.layoutService = layoutService;
         self.toggleToc = toggleToc;

src/app/ui/common/morph.directive.js

@@ -1,6 +1,5 @@
 /* global TweenLite */
 (() => {
-    'use strict';
 
     /**
      * @ngdoc directive
@@ -30,7 +29,6 @@
         .module('app.ui.common')
         .directive('rvMorph', rvMorph);
 
-    /* @ngInject */
     /**
      * `rvMorph` directive body.
      *

src/app/ui/mapnav/mapnav-button.directive.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc directive
@@ -14,14 +13,13 @@
         .module('app.ui.mapnav')
         .directive('rvMapnavButton', rvMapnavButton);
 
-    /* @ngInject */
     /**
      * `rvMapnavButton` directive body.
      *
      * @return {object} directive body
      */
     function rvMapnavButton() {
-        var directive = {
+        const directive = {
             restrict: 'E',
             templateUrl: 'app/ui/mapnav/mapnav-button.html',
             scope: {
@@ -43,7 +41,6 @@
         }
     }
 
-    /* @ngInject */
     /**
      * Skeleton controller function.
      */

src/app/ui/mapnav/mapnav.controller.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -13,7 +12,6 @@
         .module('app.ui.mapnav')
         .controller('MapNavigationController', MapNavigationController);
 
-    /* @ngInject */
     /**
      * `MapNavigationController` directive body.
      *

src/app/ui/metadata/metadata.controller.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -13,7 +12,6 @@
         .module('app.ui.metadata')
         .controller('MetadataController', MetadataController);
 
-    /* @ngInject */
     /**
      * `MetadataController` skeleton controller.
      */

src/app/ui/settings/settings.controller.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -8,15 +7,12 @@
      * @description
      *
      * The `SettingsController` controller handles the settings side panel.
+     * `SettingsController` skeleton controller.
      */
     angular
         .module('app.ui.settings')
         .controller('SettingsController', SettingsController);
 
-    /* @ngInject */
-    /**
-     * `SettingsController` skeleton controller.
-     */
     function SettingsController() {
         //var self = this;
 

src/app/ui/sidenav/sidenav.service.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc service
@@ -14,7 +13,6 @@
         .module('app.ui.sidenav')
         .factory('sideNavigationService', sideNavigationService);
 
-    /* @ngInject */
     /**
      * `sideNavigationService` exposes methods to close/open the side navigation panel.
      * @param  {object} $mdSidenav

src/app/ui/toc/toc.controller.js

@@ -9,15 +9,12 @@
      *
      * The `TocController` controller handles the layer selector (or toc) main panel.
      * Right now it's hacked together for demo purposes.
+     * `TocController` has lots of ugly code to handle state switching. Should be rewritten.
      */
     angular
         .module('app.ui.toc')
         .controller('TocController', TocController);
 
-    /* @ngInject */
-    /**
-     * `TocController` has lots of ugly code to handle state switching. Should be rewritten.
-     */
     function TocController($state, tocService) {
         const self = this;
 

src/app/ui/toolbox/toolbox.controller.js

@@ -1,5 +1,4 @@
-(function () {
-    'use strict';
+(() => {
 
     /**
      * @ngdoc function
@@ -13,7 +12,6 @@
         .module('app.ui.toolbox')
         .controller('ToolboxController', ToolboxController);
 
-    /* @ngInject */
     /**
      * `ToolboxController` skeleton controller.
      */