Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Permissions for Workspace to Allow Customization by LANDA Members (LANDA-463 / LAN-619) #165

Closed

Conversation

melanieroedel
Copy link
Contributor

Goals:

  • LANDA Members can still customize their own workspace
  • LANDA Members can reset their workspace, e.g. after an update
  • users cannot see workspaces of other users

Problem:

  • When a user customizes their workspace, it is created by the user "Administrator", not the user that was logged in
  • Workspaces are labeled with the users name (=email), which means users can see other users email addresses in the workspace title if they have read permission (as well as any secret customizations other users might have performed)

to allow customization by all landa members
landa-463
"cancel": 0,
"create": 0,
"creation": "2022-11-10 17:04:38.173952",
"delete": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeder darf beliebige Workspaces löschen? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicht schön und nur eine Notlösung, aber es geht, solange man nur seine eigenen Workspaces sieht (von denen man irgendwie der Owner ist, ohne sie erstellt zu haben). So kann man auch keine Standard Workspaces löschen.
Gerne einfach mal probieren. Ich kam durch Zufall zu dieser Lösung

"email": 0,
"export": 1,
"idx": 0,
"if_owner": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if_owner": 1 ist derzeit in aller Regel nicht der Fall

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das sollte man meinen, aber es funktioniert. Ich bin durch Ausprobieren zu dieser Lösung gekommen.

@barredterra
Copy link
Member

Maybe frappe/frappe#18795 in combination with removing read permission for "All" would solve our problems?

@barredterra barredterra changed the title Change Permissions for Workspace to Allow Customization by LANDA Members (LANDA-463) Change Permissions for Workspace to Allow Customization by LANDA Members (LANDA-463 / LAN-619) Nov 28, 2022
@melanieroedel
Copy link
Contributor Author

@barredterra As far as I can tell frappe/frappe#18795 alone, which is included in the Frappe branch landa-version-13 solves the problem.
Let's install this on landa-dev and wait for Martin's review.

@barredterra barredterra marked this pull request as draft December 5, 2022 15:34
@barredterra barredterra force-pushed the version-13-hotfix branch 2 times, most recently from 366ae33 to f21ce06 Compare December 7, 2022 10:37
@barredterra barredterra closed this Jan 5, 2023
@barredterra
Copy link
Member

To be solved in frappe: frappe/frappe#19496

@barredterra barredterra deleted the workspace-permissions-landa-463 branch January 5, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants