Make optional dependency optional #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have |
|
Updated in npm. Please, confirm. |
|
Yeah, its kind of a weird scenario that yarn is complicating, or possibly has a bug even. Thanks for understanding though! Will test today. |
|
New version solves my problems. Thanks for the speedy merge and release. Yay open source 🌈 |
|
Glad to help ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this module with yarn, but it fails to install this module on OS X because of the hard dependency on node-windows2. This uses the optional dependency field instead which seems the correct way to solve this given https://docs.npmjs.com/files/package.json#optionaldependencies