Fixed tests and lints

Jakefile

@@ -31,7 +31,12 @@ var exec = function (command, options) {
   return execute(command, options).then(complete, fail)
 }
 
-var chain = function (tasks, ignoreErrors) {
+var termination = function (error, value) {
+  error ? fail(error) : complete(value)
+}
+
+var chain = function (tasks, callback, ignoreErrors) {
+  callback = callback || termination
   tasks = tasks.map(function (task) {
     if (typeof task === 'string' || task instanceof String) {
       return jake.Task[task]
@@ -44,13 +49,15 @@ var chain = function (tasks, ignoreErrors) {
         task.invoke(value)
       })
       carrier.addListener('fail', function (error) {
-        ignoreErrors ? task.invoke(error) : fail(error)
+        ignoreErrors ? task.invoke(error) : callback(error)
       })
     }
     return task;
   }, null)
-  last.addListener('complete', complete)
-  last.addListener('fail', fail)
+  last.addListener('complete', function (value) {
+    callback(null, value)
+  })
+  last.addListener('fail', callback)
   tasks[0].invoke()
 }
 
@@ -126,7 +133,7 @@ namespace('test', function () {
   })
 
   task('with-report', {async: true}, function () {
-    chain(['test:coverage', 'test:report'], true)
+    chain(['test:coverage', 'test:report'], termination, true)
   })
 
   suites.forEach(function (suite) {
@@ -176,7 +183,7 @@ namespace('test', function () {
       })
 
       task('with-report', {async: true}, function () {
-        chain(['test:' + suite + ':coverage', 'test:report'], true)
+        chain(['test:' + suite + ':coverage', 'test:report'], termination, true)
       })
     })
   })

lib/http/_common.js

@@ -23,14 +23,12 @@ function NetworkException (message, code, request) {
   this.request = request
   this.stack = new Error().stack
 }
-// poor man's byte economy
-var N = NetworkException
-extend(Error, N, 'NetworkException')
-N.prototype.code = -1
-N.prototype.message = 'Unexpected exception during request'
+extend(Error, NetworkException, 'NetworkException')
+NetworkException.prototype.code = -1
+NetworkException.prototype.message = 'Unexpected exception during request'
 
 var index = {
-  '-1': N
+  '-1': NetworkException
 }
 
 /**
@@ -94,16 +92,24 @@ var index = {
  * @property {Function} VoxEngineErrorException
  */
 var exports = {
-  NetworkException: N,
+  NetworkException: NetworkException,
   codeExceptionIndex: index,
   Method: Schema.Method
 }
 
+/**
+ * Declares new NetworkException (resembling VoxImplant HTTP client
+ * negative response codes)
+ *
+ * @param {string} name Exception name
+ * @param {int} code Exception code (response code)
+ * @param {string} message Default exception message
+ */
 function declare (name, code, message) {
   var e = function () {
-    N.apply(this, arguments)
+    NetworkException.apply(this, arguments)
   }
-  extend(N, e, name)
+  extend(NetworkException, e, name)
   e.prototype.constructor = e
   e.prototype.code = e.code = code
   e.prototype.message = message

lib/http/_schema.js

@@ -187,8 +187,8 @@ var Method = {
  *
  * @param {Method|string} method
  * @param {string} resource
- * @param {Query|undefined} [query]
  * @param {*|undefined} [payload]
+ * @param {Query|undefined} [query]
  * @param {Headers|undefined} [headers]
  *
  * @return {RestResponsePromise}

lib/http/basic.js

@@ -76,7 +76,7 @@ function BasicHttpClient (settings, transport) {
   transport = transport || Net.httpRequestAsync
   settings = settings || {}
   var defaults = getDefaults()
-  var logger = Slf4j.assemble(setting('logger'), 'ama-team.voxengine-sdk.http.basic')
+  var logger = Slf4j.factory(setting('logger'), 'ama-team.voxengine-sdk.http.basic')
   var self = this
   var requests = 0
 

lib/http/rest.js

@@ -50,7 +50,7 @@ function JsonSerializer () {
  * @property {boolean|undefined} retryOnServerError Whether request should be retried on server error (5xx),
  *   default: `true`
  * @property {Headers|undefined} headers Object containing headers for every emitted request, default: `{}`
- * @property {VarArgLoggerFactory} loggerFactory Factory for logger creation.
+ * @property {LoggerOptions} logger Logger options.
  * @property {IHttpClient} client Underlying http client
  */
 
@@ -82,7 +82,7 @@ function RestClient (settings, transport) {
   })
   client = settings.client || new Client(opts, transport)
   // noinspection JSUnusedAssignment
-  logger = Slf4j.assemble(opts.logger, 'ama-team.voxengine-sdk.http.rest')
+  logger = Slf4j.factory(opts.logger, 'ama-team.voxengine-sdk.http.rest')
 
   function execute (request) {
     var id = ++counter
@@ -165,6 +165,9 @@ function RestClient (settings, transport) {
   })
 }
 
+/**
+ * @return {RestClientSettings}
+ */
 function getDefaults () {
   return {
     url: '',

lib/index.js

@@ -1,4 +1,10 @@
-module.exports = {
-  http: require('./http'),
-  logger: require('./logger')
+var exports = {
+  Http: require('./http'),
+  Logger: require('./logger')
 }
+/** @deprecated */
+exports.http = exports.Http
+/** @deprecated */
+exports.logger = exports.Logger
+
+module.exports = exports