Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for track_event method #2

Closed
wants to merge 4 commits into from
Closed

Add a check for track_event method #2

wants to merge 4 commits into from

Conversation

rubene
Copy link
Member

@rubene rubene commented Feb 20, 2014

  • Add a check for webtrends_tags if is nil it should not track event.
  • Fix model_spec test.
  • bump gem version.

@rubene
Add a check for track_event method
bbdc5e3 
* Add a check for webtrends_tags if is nil it should not track event.
* Fix model_spec test.
* bump gem version.
@rubene
Add missing attribute for test to avoid false positive
c933433
jbabe
jbabe reviewed Feb 21, 2014
View reviewed changes
spec/models/model_spec.rb
subject.webtrends_tags = {"WT.waffles" => '1'}
end

context 'successfull load' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo => 'successful'

@mvandenbeuken
Copy link
Member

Removing the check for nil tags and moving the logic to the webtrends gem. Closing this PR and reopening a new one to cover the typos.

@mvandenbeuken mvandenbeuken deleted the fix_check_tag_present branch February 21, 2014 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rubene @mvandenbeuken @jbabe