Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for Service_IntegratedCatalogue implementation #80

Closed
zhaonan0218 opened this issue Jun 26, 2017 · 5 comments
Closed

Request for Service_IntegratedCatalogue implementation #80

zhaonan0218 opened this issue Jun 26, 2017 · 5 comments
Labels
new message
Milestone
1.5.0

Comments

@zhaonan0218
Copy link

This is a request for message Service_IntegratedCatalogue implementation that is in the to-do list, thank you very much! 👍
@DerMika
Copy link
Collaborator

DerMika commented Aug 10, 2017

I don't have the time right now to implement this.

For anyone who wants to do this, check out a rough guideline of how to do this in this comment on issue #79

@DerMika
Copy link
Collaborator

DerMika commented Sep 4, 2017

Hi, can you please list which options of this message you'd need? I'd like to try to implement at least basic support for this message.

@zhaonan0218
Copy link
Author

Sorry DerMika, just saw your reply. The data we are trying to retrieve from this message are the list of services names/descriptions/names.
Thank you!

@DerMika DerMika added this to the 1.5.0 milestone Oct 19, 2017
DerMika added a commit that referenced this issue Nov 5, 2017
@DerMika
Implementation of Service_IntegratedCatalogue (issue #80)
374ab89
@DerMika
Copy link
Collaborator

DerMika commented Nov 5, 2017

I finally implemented this message. Turns out it wasn't a lot of work, since the messages structure and options are identical to Service_IntegratedPricing! Check out the documentation.

You can test the message by switching your composer.json to dev-master.

Support for this message will be released in the 1.5.0 release.

@DerMika DerMika closed this as completed Nov 5, 2017
@DerMika
Copy link
Collaborator

DerMika commented Nov 10, 2017

Version 1.5.0 has been released.

atomy pushed a commit to mlamm/amadeus-ws-client that referenced this issue Nov 26, 2018
@mlamm
Merge pull request amabnl#80 in FLIGHT/service.amadeus from phiremock…
d9f6ca3 
…-for-tests to master

* commit '8d0f73faa11187c33307f3896e0da2a1bfd42c52':
  - cleanup
  - cleanup
  - refactoring tests to phiremock
  - refactoring tests to phiremock
  - refactoring tests to phiremock
  - refactoring tests to phiremock
  - refactoring tests to phiremock
  - refactoring some tests to be rely on phiremock instead of custom mock handler
  - refactoring some tests to be rely on phiremock instead of custom mock handler
  - tweaks
  - introducing phiremock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new message
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@DerMika @zhaonan0218