Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with not well formed Auth header #15

Merged
merged 1 commit into from
Sep 11, 2016

Conversation

smgladkovskiy
Copy link
Contributor

Hi.

I tried to use develop branch to make some requests and faced with auth problems:

first:

PHP Fatal error:  SOAP-ERROR: Encoding: object has no 'SessionId' property in /path/to/amadeus-ws-client/vendor/amabnl/amadeus-ws-client/src/Amadeus/Client/Session/Handler/Base.php on line 212

after fixing first one:

  SOAPFAULT while sending message Fare_MasterPricerTravelBoardSearch:  12|Presentation|soap message header incorrect code: 0 at /path/to/amadeus-ws-client/vendor/amabnl/amadeus-ws-client/src/Amadeus/Client/Session/Handler/Base.php line 212:

on any request.

After some investigations I figured out the problems. I made some changes which allows to run the code without errors.

P.S. Tests are ignores the problems, so my changes didn't influenced on its greens.

* lowercase node names
* wrong secure node name (was SessionId, but needed Session)
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e8e9be9 on smgladkovskiy:soap-2-session-headers into * on amabnl:develop*.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 10, 2016

Coverage Status

Changes Unknown when pulling e8e9be9 on smgladkovskiy:soap-2-session-headers into * on amabnl:develop*.

@DerMika
Copy link
Collaborator

DerMika commented Sep 11, 2016

Hi,

First of all, thanks a lot! You're probably the first using the Soap Header 2 implementation, because I've been unable to obtain a WSAP for Soap Header 2 to actually test my code.

With these changes, are you now able to send messages with a Soap Header 2 WSAP?

@DerMika DerMika added the bug label Sep 11, 2016
@smgladkovskiy
Copy link
Contributor Author

You're probably the first using the Soap Header 2 implementation

And I'm going to use your code (pretty well-written, by the way) to implement connection to Amadeus Web Services in my project. So if something will be wrong my crew and I will help you to maintain and improve your code! ;)

With these changes, are you now able to send messages with a Soap Header 2 WSAP?

Yeap! Sessions now work flawlessly.

@smgladkovskiy
Copy link
Contributor Author

By the way! On develop branch you didn't update code usage examples for authentication routine. Is there more places where docs are so outdated?

@DerMika
Copy link
Collaborator

DerMika commented Sep 11, 2016

I'm not sure what you mean. I have both a Soap Header 4 and a Soap Header 2 example on https://github.com/amabnl/amadeus-ws-client/blob/develop/docs/about-get-started.rst#set-up-a-test-client - is anything missing? Please open an issue or submit a pull request if you feel that there's documentation missing - or wrong!

@DerMika DerMika merged commit 79a83dc into amabnl:develop Sep 11, 2016
@DerMika DerMika added this to the 1.0 milestone Nov 6, 2017
atomy pushed a commit to mlamm/amadeus-ws-client that referenced this pull request Nov 26, 2018
…N-456-service.amadeus-search-prevent-warning to master

* commit '676325f94aa5637069531cd8c089f99dc77374bd':
  VAN-456 service.amadeus / search / prevent warning on invalid inputs updated validator updated request handling updated test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants