Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ZAP-Off and accountCode in Queue_List #344

Merged
merged 59 commits into from
May 28, 2020

Conversation

suiram2010
Copy link
Contributor

@suiram2010 suiram2010 commented Jun 25, 2019

Implementation of ZAP-Off for PricePnrWithBookingClass
Queue_List add accountNumber to the request
Implementation of Fare Family per segments (possibility to add fare families per segments)

@coveralls
Copy link

coveralls commented Jun 25, 2019

Coverage Status

Coverage increased (+0.002%) to 99.773% when pulling f661eef on techork:develop into 404d2e6 on amabnl:master.

@suiram2010
Copy link
Contributor Author

suiram2010 commented Jun 26, 2019

@DerMika Is there a way to pass Scrutinizer php56 module test? I testet on master branch and it also fails? Thank You.

@DerMika
Copy link
Collaborator

DerMika commented Jul 2, 2019

I will have a look when I have some time...

@suiram2010
Copy link
Contributor Author

@DerMika can you have a look at this pull request, I merged with the latest changes from master and passed the checks again

@DerMika
Copy link
Collaborator

DerMika commented May 27, 2020

Losing some coverage in src/Amadeus/Client/Struct/Pnr/AddMultiElements/DataElementsIndiv.php - can you fix that?

@DerMika
Copy link
Collaborator

DerMika commented May 27, 2020

and in the future please provide a separate pull request for each individual change you make

@suiram2010
Copy link
Contributor Author

@DerMika thank you for pointing to errors I made. Please have a look again at the fixes I made. Thank you

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

https://coveralls.io/builds/31083083 Coveralls still reporting coverage dropped in that file

also in Client.php

@suiram2010
Copy link
Contributor Author

suiram2010 commented May 28, 2020

@DerMika Sorry fixed my errors by as I see re remaining errors deals to Ticket_ATCShopperMasterPricerCalendar not implemented by me, my branch has nothing assotiated with Ticket_ATCShopperMasterPricerCalendar

@DerMika can you please figure it out what's the problem

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

i will check it

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

yeah I apparently merged a PR which didn't have 100% coverage, shame on me

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

Would you please add all changes in this PR to the CHANGELOG.MD file?

@suiram2010
Copy link
Contributor Author

@DerMika updated the CHANGELOG.MD.
Thnak you.

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

looks like you have a merge conflict. I updated the readme yesterday when I published version 1.10.0. Can you resolve the conflict please?

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

i fixed the conflict

@suiram2010
Copy link
Contributor Author

@DerMika Thank you, sorry I was away ffrom PC

@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

No problem!

@DerMika DerMika merged commit 7c59daa into amabnl:master May 28, 2020
@DerMika
Copy link
Collaborator

DerMika commented May 28, 2020

Thanks for contributing! (and sorry it took me such a long time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants