-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of ZAP-Off and accountCode in Queue_List #344
Conversation
…lementation_for_PricePnrWithBookingClass
@DerMika Is there a way to pass Scrutinizer php56 module test? I testet on master branch and it also fails? Thank You. |
I will have a look when I have some time... |
@DerMika can you have a look at this pull request, I merged with the latest changes from master and passed the checks again |
Losing some coverage in |
and in the future please provide a separate pull request for each individual change you make |
@DerMika thank you for pointing to errors I made. Please have a look again at the fixes I made. Thank you |
https://coveralls.io/builds/31083083 Coveralls still reporting coverage dropped in that file also in Client.php |
i will check it |
yeah I apparently merged a PR which didn't have 100% coverage, shame on me |
Would you please add all changes in this PR to the CHANGELOG.MD file? |
@DerMika updated the CHANGELOG.MD. |
looks like you have a merge conflict. I updated the readme yesterday when I published version 1.10.0. Can you resolve the conflict please? |
i fixed the conflict |
@DerMika Thank you, sorry I was away ffrom PC |
No problem! |
Thanks for contributing! (and sorry it took me such a long time) |
Implementation of ZAP-Off for PricePnrWithBookingClass
Queue_List add accountNumber to the request
Implementation of Fare Family per segments (possibility to add fare families per segments)