Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Function: MiniRule_GetFromRec #417

Merged
merged 17 commits into from
Dec 12, 2020
Merged

Add Function: MiniRule_GetFromRec #417

merged 17 commits into from
Dec 12, 2020

Conversation

gregsparrow
Copy link
Contributor

@gregsparrow gregsparrow commented Sep 24, 2020 •
edited

Amadeus docs emphasize to use MiniRule_GetFromRec instead of MiniRule_GetFromETicket, MiniRule_GetFromPricing, MiniRule_GetFromPricingRec

closes #415

@gregsparrow gregsparrow reopened this Sep 24, 2020
@coveralls
Copy link

coveralls commented Sep 24, 2020 •
edited

Coverage Status

Coverage increased (+0.0005%) to 99.849% when pulling 5368c17 on gregsparrow:master into 95f9a6a on amabnl:master.

@gregsparrow gregsparrow mentioned this pull request Sep 24, 2020
Closed
cavaon-wayne
cavaon-wayne reviewed Nov 30, 2020
View reviewed changes
Copy link

@cavaon-wayne cavaon-wayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "$name" to src/Amadeus/Client/RequestOptions/MiniRule/Language.php and change related Struct Class.

@DerMika DerMika merged commit 2c64678 into amabnl:master Dec 12, 2020
@DerMika
Copy link
Collaborator

DerMika commented Dec 12, 2020

Thanks for contributing!

@DerMika
Copy link
Collaborator

DerMika commented Feb 18, 2021

released v1.12.0 which includes this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavaon-wayne cavaon-wayne cavaon-wayne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MiniRule_GetFromRec is missing
4 participants
@gregsparrow @coveralls @DerMika @cavaon-wayne