Skip to content

Commit

Permalink
Only run coverage if nosetests succeeds
Browse files Browse the repository at this point in the history
Travis should not have been passing with broken tests. I suspect that
coverage being run regardless of nosetests return code was masking the
return code from nosetests. Causing Travis to consider the build
successful even though tests failed.
  • Loading branch information
amacd31 committed Aug 10, 2017
1 parent 8085167 commit 76a17a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ install:
- conda build --python=$TRAVIS_PYTHON_VERSION conda.recipe
- conda install -y --use-local phildb
script:
- nosetests tests -a '!performance' --cover-erase --with-coverage --cover-package=phildb --cover-html --with-xunit; coverage xml --rcfile=.coveragerc
- nosetests tests -a '!performance' --cover-erase --with-coverage --cover-package=phildb --cover-html --with-xunit && coverage xml --rcfile=.coveragerc
after_success:
- echo anaconda --token XXXX upload `python ci/get_labels.py` `conda build --python=$TRAVIS_PYTHON_VERSION conda.recipe --output`
- anaconda --token $CONDA_TOKEN upload `python ci/get_labels.py` `conda build --python=$TRAVIS_PYTHON_VERSION conda.recipe --output`
Expand Down

0 comments on commit 76a17a4

Please sign in to comment.