-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded FS on Windows #536
Comments
@Dissociable thanks for reporting this. This makes me wonder: is it worth investing time in extending our CI test to add a Windows runner to test dbmate on, as well? Similarly, should we add a macOS runner, too? I know that GitHub hosted Windows and Mac action runners are considerably more expensive, and I don't know if @amacneil wants to incur those costs for the project or not. |
@Dissociable contact with me in discord |
- Run unit tests on all platforms to discover/prevent issues like #536 - Change dbmate package unit tests to use sqlite instead of postgres (i.e. no external dependency, although sqlite binary is currently still required due to `dbmate dump` tests) - Integration tests can be run by passing the appropriate env vars such as `POSTGRES_TEST_URL`. If URLs are not provided they will be skipped. - In CI we only run integration tests in the linux docker job.
Description
Basically, this is a bug only for Windows.
readMigrationsDir
sets the dir path viafilepath.Clean(dir)
which changes the/
to\
on Windows.fs.ReadDir
Is not able to handle that. changingfilepath.Clean(...)
topath.Clean(...)
would simply fix it.Steps To Reproduce
Expected Behavior
Find the embedded files at
migrate/migrations
The text was updated successfully, but these errors were encountered: