New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding verbose output for statement execution #138
Conversation
changed name from |
@amacneil - not sure how to assign reviewers |
Hey, sorry for the delay on this, it has been a busy few days. Some quick thoughts/feedback:
Otherwise looks good, thanks for the contribution! |
thanks for the comments, no worries. I think I've addressed these concerns with the new commit:
|
@amacneil bump |
@amacneil sorry for the pestering, but any chance you would be able to look at this soon? we feel that without this logging we are missing a crucial sanity check when running our db migrations at scale |
Cool, this looks good. Sorry I have been busy lately and not much time for OSS. I added you as a contributor, so if you're happy with it and it's passing CI feel free to merge! |
@amacneil thank you! no worries, I appreciate it. |
Adding a verbose command line flag to allow users to print the result of each statement execution. Should not disrupt the existing flow for users as it's completely optional. Summary of changes:
verbose
flagdb
to print result of migrationsexec
based on verbose flag across db and drivers