Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: host query param default, fix #317 #318

Merged
merged 1 commit into from Sep 20, 2022
Merged

fix: host query param default, fix #317 #318

merged 1 commit into from Sep 20, 2022

Conversation

niclaslovdahl
Copy link
Contributor

@niclaslovdahl niclaslovdahl commented Sep 19, 2022 •
edited by amacneil

Fixes #317
Fixes #291

amacneil
amacneil approved these changes Sep 20, 2022
View reviewed changes
Copy link
Owner

@amacneil amacneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the additional tests!

@amacneil amacneil merged commit e53843b into amacneil:main Sep 20, 2022
@marcusthelin
Copy link

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacneil amacneil amacneil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

providing host as query param will result in default host value
3 participants
@niclaslovdahl @marcusthelin @amacneil